search

accord-net / framework

Machine learning, computer vision, statistics and general scientific computing for .NET
http://accord-framework.net
GNU Lesser General Public License v2.1
4.49k stars 1.99k forks source link

Build-all.cmd Does Not Correctly Parse 2019 #1830

Open kjkazinski opened 5 years ago

kjkazinski commented 5 years ago

What would you like to submit? (put an 'x' inside the bracket that applies)

Issue description

If you would like to submit an issue, please include a sample of the code you are trying to execute, as well as any data you might be using in your experiment, such as data tables, images, anything that might be necessary to reproduce the problem.

Note: If you would like to support the development for this feature or resolution of this bug, consider adding a bounty to it later in https://www.bountysource.com/teams/accord-net/issues

kjkazinski commented 5 years ago

The current cmd file does not correctly find VS if the latest version is 2019.

:: Use Microsoft's vswhere.exe to locate the appropriate version of MSBuild: for /f "usebackq tokens=1* delims=: " %%i in (Tools\vswhere -latest -requires Microsoft.Component.MSBuild) do ( if /i "%%i"=="installationPath" set InstallDir=%%j ) set MSBUILD="%InstallDir%\MSBuild\15.0\Bin\MSBuild.exe"

Should be: for /f "usebackq tokens=" %%i in (`vswhere -latest -requires Microsoft.Component.MSBuild -find MSBuild*\Bin\MSBuild.exe`) do ( set MSBUILD="%%i" )

fdncred commented 5 years ago

will accept a pr for this