accordproject / cicero-template-library

Accord Project Template Library
https://templates.accordproject.org
Apache License 2.0
83 stars 94 forks source link

feature(build) Switches from TravisCI to GitHub actions #380

Closed Aniruddha-Shriwant closed 3 years ago

Aniruddha-Shriwant commented 3 years ago

Related Issue #379

Changes

Author Checklist

Aniruddha-Shriwant commented 3 years ago

Do we need deploy.yml like this:

name: 'Netlify Preview Deploy'

on:
  pull_request:
    types: ['opened', 'edited', 'synchronize']

jobs:
  deploy:
    name: 'Deploy'
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v1
      - uses: jsmrcaga/action-netlify-deploy@master
        with:
          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
          NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}

Or the Netlify App will do the work of deployment?

jeromesimeon commented 3 years ago

Do we need deploy.yml like this:

name: 'Netlify Preview Deploy'

on:
  pull_request:
    types: ['opened', 'edited', 'synchronize']

jobs:
  deploy:
    name: 'Deploy'
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v1
      - uses: jsmrcaga/action-netlify-deploy@master
        with:
          NETLIFY_AUTH_TOKEN: ${{ secrets.NETLIFY_AUTH_TOKEN }}
          NETLIFY_SITE_ID: ${{ secrets.NETLIFY_SITE_ID }}

Or the Netlify App will do the work of deployment?

I don't think we need any change for Netlify. In theory the Concerto scripts should work as is. Netlify will deploy automatically.

Aniruddha-Shriwant commented 3 years ago

I don't think we need any change for Netlify. In theory the Concerto scripts should work as is. Netlify will deploy automatically.

Okay

jeromesimeon commented 3 years ago

@Aniruddha-Shriwant Can you please change the issue description: this will only be addressing part of #379

Aniruddha-Shriwant commented 3 years ago

@Aniruddha-Shriwant Can you please change the issue description: this will only be addressing part of #379

Is it okay now?