accordproject / cicero-template-library

Accord Project Template Library
https://templates.accordproject.org
Apache License 2.0
80 stars 93 forks source link

Add Open In Vscode Option #416

Closed Ayman161803 closed 2 years ago

Ayman161803 commented 2 years ago

Signed-off-by: Ayman161803 mohammedaymannawaz@gmail.com

Closes #

Changes

Flags

Screenshots or Video

image

Related Issues

Author Checklist

mttrbrts commented 2 years ago

Love it! ❤️

mttrbrts commented 2 years ago

@Ayman161803 I'm happy for you to run node run.js to rebuild the static pages, do you want to add a commit to this PR with the changes?

Ayman161803 commented 2 years ago

I have updated the PR after running node run.js

Ayman161803 commented 2 years ago

I will have a look at this👍🏻

Ayman161803 commented 2 years ago

@mttrbrts I am having trouble generating the HTML files for dropdowns after running node run.js. The HTML in the sample screenshot was obtained after running SKIP_DROPDOWN=True node run.js which I think skips dropdowns. Can you please push changes to this branch or direct me on how to update all HTML files? Thank you.

mttrbrts commented 2 years ago

I've made some (rather hacky!) changes which add the button to all static pages. This approach of building static pages is breaking down.

I'm happy to make this kind of change to unblock you, but the maintainers should review the design of this build process.

To recreate you can run ADD_VSCODE_BUTTON=true SKIP_DROPDOWNS=true npm run build