search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

Missing entries in .gitignore #289

Closed adrijshikhar closed 4 years ago

adrijshikhar commented 4 years ago

Describe the bug .vsocde and .dist are two folders that are created by Visual Studio Code. .vscode contains the local settings for that workspace. .dist is created by C++ extension in vscode. These are local changes made and hence should be present in .gitignore so that no one accidentally commits these files.

To Reproduce Steps to reproduce the behavior:

  1. Open a terminal and go to the root of the repo
  2. Type code . and let vsocde open
  3. Go back to the terminal and type ls
  4. See the error, two new folders will be created if you use custom settings and C++ extension

Expected behavior .vscode and .dist should be present in .gitignore

Screenshots Screenshot_20200221_222352

Desktop (please complete the following information):

irmerk commented 4 years ago

I'm not sure I understand the purpose of this, I don't think the repository has an issue with a .vscode or .dist folder.

adrijshikhar commented 4 years ago

.vscode contains a file named settings.json, which contains the local settings for the vscode in that particular workspace. So if anyone accidentally commits this, and some other guy pulls his changes and his vscode will create its own settings.json which will increase the number of line changes and might break some of the custom changes that this user has applied to his vscode.