feat(ClauseComponent): UI enhancements to ClauseComponent

accordproject / cicero-ui

A library of React components for Accord Project templates

Apache License 2.0

29 stars 45 forks source link

feat(ClauseComponent): UI enhancements to ClauseComponent #324

Closed elit-altum closed 4 years ago

elit-altum commented 4 years ago

Signed-off-by: elit-altum manan.sharma311@gmail.com

Continues https://github.com/accordproject/cicero-ui/pull/318 by creating a different PR for UI styling of ClauseComponent

Changes

Increased the padding of ClauseBody
Removed the borders for a cleaner look

Screenshot

Related Issues

Issue https://github.com/accordproject/markdown-editor/issues/124
Pull Request #318

elit-altum commented 4 years ago

@irmerk @Michael-Grover Please review!

jolanglinais commented 4 years ago

I believe this comment was addressing the changes that are now in this PR. I think we don't want to move away from the border of the clauses. @Michael-Grover confirm?

elit-altum commented 4 years ago

@Michael-Grover thoughts ?

Michael-Grover commented 4 years ago

These changes make clause templates too difficult to distinguish from contract text, so I think we can close this

elit-altum commented 4 years ago

These changes make clause templates too difficult to distinguish from contract text, so I think we can close this

There are more changes regarding the spacing and the removal of border radius as well. I can add the borders again and then can we look at this @Michael-Grover? As mentioned here https://github.com/accordproject/markdown-editor/issues/124#issuecomment-592392350

Michael-Grover commented 4 years ago

The increased spacing causes the clause text to be misaligned with the contract text. I think these changes are subjective aesthetic changes, which we should avoid because multiple people could endlessly fiddle around with the aesthetics of Accord Project components based on their personal opinions on UI design.

elit-altum commented 4 years ago

The increased spacing causes the clause text to be misaligned with the contract text. I think these changes are subjective aesthetic changes, which we should avoid because multiple people could endlessly fiddle around with the aesthetics of Accord Project components based on their personal opinions on UI design.

I understand @Michael-Grover. I thought the changes suggested here https://github.com/accordproject/markdown-editor/issues/124#issuecomment-592392350 were approved before.