search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

Broken Links in Readme.md #328

Closed a4aditya closed 4 years ago

a4aditya commented 4 years ago

Describe the bug The Link for the highlighted text on the screenshot is broken. The two of the component don't have a repository also. Link to the Readme File: https://github.com/accordproject/cicero-ui/blob/master/README.md #3

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Readme.md'
  2. Scroll down to 'Implementation'
  3. See error

Expected behaviour The link should provide a link to the Readme.md file for every component

sanyamdogra commented 4 years ago

Hi @a4aditya, The components you mentioned are under the heading "Still in development". I guess once they will be developed, these links will have their meaning.

irmerk commented 4 years ago

Yes they probably should not have been linked in the first place, but they are not at their first stage yet. You could remove the links or close this issue.

sanyamdogra commented 4 years ago

I guess it's a minor fix, should I make a PR with removing the link? @irmerk

irmerk commented 4 years ago

Sure thing