search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 45 forks source link

Conditional Variable is Editable #339

Closed jolanglinais closed 4 years ago

jolanglinais commented 4 years ago

Describe the bug Conditional variables are editable

To Reproduce Steps to reproduce the behavior:

  1. Go to the demo
  2. Click on before the conditional variable
  3. Right arrow into the conditional variable
  4. Type

Expected behavior This should be protected and not allowed

jerrybuks commented 4 years ago

Let me fix this.

jerrybuks commented 4 years ago

should

Describe the bug Conditional variables are editable

To Reproduce Steps to reproduce the behavior:

  1. Go to the demo
  2. Click on before the conditional variable
  3. Right arrow into the conditional variable
  4. Type

Expected behavior This should be protected and not allowed

should this be protected, only when lockTestState is true or should it be protected whether or not lockTestState is true/false?

jolanglinais commented 4 years ago

I believe we have isEditable functions that check to make sure a user can type already. So a conditional variable should be treated the same as non-variable text in that a user should not be able to edit it. And yes I think this all pertains to lockText being true.

jerrybuks commented 4 years ago

I believe we have isEditable functions that check to make sure a user can type already. So a conditional variable should be treated the same as non-variable text in that a user should not be able to edit it. And yes I think this all pertains to lockText being true.

yeah, on it