search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

feat(*): add storybook for developer focused demo - I315 #353

Closed sanyamdogra closed 4 years ago

sanyamdogra commented 4 years ago

Issue #315

### Changes - Adds `@storybook/react` as a dependency. - Access Storybook at port 9001 by running `npm run storybook`. - Component stories can be added in `src/stories` folder with extension `.stories.js` ### Flags - N.A ### Related Issues - Issue #315 ### Screenshots ![image](https://user-images.githubusercontent.com/33497630/76977796-d1249f00-695b-11ea-8f06-2770401cb5c8.png) ![image](https://user-images.githubusercontent.com/33497630/76977849-e5689c00-695b-11ea-8787-fade150b7873.png)
irmerk commented 4 years ago

This is done with @elit-altum as far as I understand.

jeromesimeon commented 4 years ago

This is done with @elit-altum as far as I understand.

Can you clarify this? Who wrote the code, and who signed the DCO?

irmerk commented 4 years ago

@jeromesimeon see the work in #335

irmerk commented 4 years ago

@sanyamdogra can you check to ensure these changes are still in master?

sanyamdogra commented 4 years ago

Hi @irmerk, Yes they have been added to the master.