search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 45 forks source link

[FEATURE] Add a shortcut list modal #354

Closed nik72619c closed 4 years ago

nik72619c commented 4 years ago

Is your feature request related to a problem? Please describe. Currently, there is no modal which could show a list of shortcuts. This could be helpful for people to view them in one place rather than hover on each one of them.

Describe the solution you'd like Create a button which could trigger a modal, displaying a list of shortcuts in the demo.

Additional context I would like to implement it.

jolanglinais commented 4 years ago

@Michael-Grover any thoughts on this?

Michael-Grover commented 4 years ago

@nik72619c can you show examples of other products that do something like this?

Michael-Grover commented 4 years ago

I'm not sure if this is necessary. There's already a list of shortcuts in the documentation

nik72619c commented 4 years ago

I saw something in the following project, and thats why this struck my mind :- https://vega.github.io/editor/#/

The shortcut list can be found under the help modal.

Michael-Grover commented 4 years ago

this product has way more shortcuts than we have, and our shortcuts are mostly standard ones like cmd+b or cmd+k. I don't think a shortcut list within the UI is necessary for the number of shortcuts we have.