accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

feat(TemplateLibrary): add fallback message if template is not found #361

Closed nik72619c closed 4 years ago

nik72619c commented 4 years ago

Signed-off-by: nik72619c nikhilsharmarockstar21@gmail.com

Issue #359

Added a fallback message which would indicate that no results were found if on search, no template could be found

Changes

Screenshot 2020-03-29 at 8 48 14 PM

@irmerk @Michael-Grover let me know of any design changes on this, will add it this PR :)

Michael-Grover commented 4 years ago

https://www.nngroup.com/articles/search-no-results-serp/

check out this article and see if it gives you any inspiration for how to improve this. I would suggest at the minimum changing the text to say "No results found" instead of "no results found !"

nik72619c commented 4 years ago

@DianaLease @Michael-Grover made the required changes! cc @irmerk

nik72619c commented 4 years ago

working on it !