search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

chore(dep) Upgrade dependencies for Cicero 0.20.10 #370

Closed jeromesimeon closed 4 years ago

jeromesimeon commented 4 years ago

Signed-off-by: Jerome Simeon jeromesimeon@me.com

This upgrades dependencies for:

jeromesimeon commented 4 years ago

I might be missing something, but why not do proper releases of markdown-editor and cicero-core before upgrading?

Done!

irmerk commented 4 years ago

Should this be pointing to the release from markdown-editor that comes from the Slate47 branch we are going to make?

DianaLease commented 4 years ago

Should this be pointing to the release from markdown-editor that comes from the Slate47 branch we are going to make?

I don't think we need a new release after we make the branch.

jeromesimeon commented 4 years ago

Should this be pointing to the release from markdown-editor that comes from the Slate47 branch we are going to make?

I don't think so. If we do that we cannot do the automated release (which only works on master). I think the plan is to save that trouble and do the release first, then create the slate47 branch to reflect the release.

As far as I know we are not planning to do a release of the markdown editor from the slate47 branch (unless we really have to). Markdown editor has already been release anyway.

Note: this is a comment which is independent from this PR. This PR only updates the dependencies.