search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

Storybook packaged as a dependency #376

Closed dselman closed 4 years ago

dselman commented 4 years ago

https://github.com/accordproject/cicero-ui/blob/master/package.json#L28

Should story book be a dependency? How does this impact bundle size?

arteevraina commented 4 years ago

@dselman I would like to work on this.

irmerk commented 4 years ago

This ties in with #358 and #315, @98lenvi is working on it.

DianaLease commented 4 years ago

@98lenvi I would check out the install docs here: https://storybook.js.org/docs/guides/guide-react/#step-1-add-dependencies

Looks like it can be a dev dependency.