accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

Can apply bold and italics to inline code #385

Closed dselman closed 4 years ago

dselman commented 4 years ago

Describe the bug You can use the toolbar to add both bold and italics to inline code. I don't think this is valid markdown and won't roundrip through the markdown transform.

To Reproduce

  1. Go to https://cicero-ui.netlify.com
  2. Click "code"
  3. Press the bold and italic button
  4. See code, italic and bold are all applied to the text (see screenshot).

Expected behavior You should not be able to apply formatting to code.

Screenshots

Screenshot 2020-04-14 at 19 01 23

Desktop (please complete the following information):

dselman commented 4 years ago

I take it back... I DOES appear to be valid commonmark. Just verified with the Dingus:

Try CommonMark

You can try CommonMark here. This dingus is powered by commonmark.js, the JavaScript reference implementation.

jeromesimeon commented 4 years ago

Sure is 😉

jeromesimeon commented 4 years ago

For posterity/future reference:

Screenshot 2020-04-14 at 2 08 23 PM