accordproject / cicero-ui

A library of React components for Accord Project templates

Apache License 2.0

29 stars 46 forks source link

feat(index.js): added css for blockquotes #389

Closed arteevraina closed 4 years ago

arteevraina commented 4 years ago

Signed-off-by: Arteev Raina arteevraina@gmail.com

Issue #375

CSS for the BlockQuotes has been added. Now, on using Blockquotes does not changes Line-height.

Screenshot

Related Pull Request

Previous Pull Request #383

Please Review and suggest changes @DianaLease @irmerk @Michael-Grover :)

Michael-Grover commented 4 years ago

This looks great apart from the issue Diana found

arteevraina commented 4 years ago

@DianaLease I have made the changes for storybook demo. Now, blockquotes are working in storybook demo too.

irmerk commented 4 years ago

@DianaLease I think we are leaving this up to the consumer to dictate, so in this case we need to specify in the demo - which is why we need to do this in both the demo and the Storybook.

DianaLease commented 4 years ago

@DianaLease I think we are leaving this up to the consumer to dictate, so in this case we need to specify in the demo - which is why we need to do this in both the demo and the Storybook.

Got it. I think as a separate issue, we'll want the demo component and the demo storybook component to use the same code.