search

accordproject / cicero-ui

A library of React components for Accord Project templates
Apache License 2.0
29 stars 46 forks source link

Undoing After deleting values before "." breaks the editor #393

Closed jerrybuks closed 4 years ago

jerrybuks commented 4 years ago

Describe the bug After deleting numbers before a decimal point, undoing to a certain point breaks the editor.

Steps to reproduce the behavior:

  1. Go to the demo
  2. In the demo section, scroll down to the bottom where you have the bulleted list
  3. place you cursor at the end of the line of any of the list items (i.e after the percentage sign)
  4. move your cursor left to just before the first decimal point '.'
  5. hit backspace about two times and undo about three times, the editor breaks.

Expected behavior The editor should not break

Screenshots https://www.loom.com/share/e329553e4fec4b2fbc89f6e2cffb1ddd

Desktop (please complete the following information):

irmerk commented 4 years ago

This may be the same issue in https://github.com/accordproject/cicero-ui/issues/378, keeping open for now.

jerrybuks commented 4 years ago

This may be the same issue in #378, keeping open for now.

I think they looked similar, but noticed the PR you linked in #378 stopped the editor from breaking, but this issue still persisted

irmerk commented 4 years ago

@jerrybuks I don't see t he issue persisting in this build.

jerrybuks commented 4 years ago

@jerrybuks I don't see t he issue persisting in this build.

yeah, its fixed!