accordproject / cicero-word-add-in

A plugin to allow users to interact with Accord Project templates directly in MS Word.
Apache License 2.0
19 stars 9 forks source link

WIP: feat(TemplateLibrary): alternate way to add Content Control - #55 #58

Closed Aniruddha-Shriwant closed 2 years ago

Aniruddha-Shriwant commented 3 years ago

Signed-off-by: Aniruddha Shriwant aniruddhashriwant@gmail.com

Closes #55

Changes

Screenshots or Video

image As you can see the content controls are added successfully

Author Checklist

algomaster99 commented 3 years ago

@Aniruddha-Shriwant Forgot to suggest one more thing. We can also make these changes for the insertVariable method in utils/CiceroMarkToOOXML.

Aniruddha-Shriwant commented 3 years ago

@Aniruddha-Shriwant Forgot to suggest one more thing. We can also make these changes for the insertVariable method in utils/CiceroMarkToOOXML.

@algomaster99 I'm not sure how to integrate these similar changes in utils/CiceroMarkToOOXML.js for insertVariable but I will give it a try :)

Aniruddha-Shriwant commented 3 years ago

I apologize for re-requesting the review 😄 I just clicked it by mistake :)

algomaster99 commented 3 years ago

@Aniruddha-Shriwant are you still working on this?

Aniruddha-Shriwant commented 3 years ago

@Aniruddha-Shriwant are you still working on this?

@algomaster99 I apologize for the delay I was getting some errors in debugging also I was a little confused about the implementation part

algomaster99 commented 3 years ago

No problem. I was just taking an update :)

Aniruddha-Shriwant commented 3 years ago

No problem. I was just taking an update :)

@algomaster99 I will work on this soon and maybe I would need your little help on this :)

Aniruddha-Shriwant commented 3 years ago

@algomaster99, I had spent some time on this but I was not able to add the cannotEdit API to utils/CiceroMarkToOOXML.js for insertVariable as I was getting some problems in getting all the variables present in the document in the Range class format because without it I won't be able to add contentControls on them, also the current way of adding contentControl is working fine, maybe we can do this later in another PR. What are your thoughts on this?