accordproject / concerto-docs

Concerto Data Model Language Documentation Site

Apache License 2.0

2 stars 15 forks source link

fix(docs-website): fix dark theme behaviour - I39 #40

Closed apoorvsxna closed 7 months ago

apoorvsxna commented 8 months ago

Closes #39

Fixed inconsistent behaviour of the elements mentioned in the issue, when switching the display theme (light to dark, or back).

Changes

Changed the styling of feature icons so that their colors adjust when switching themes.
Included an image for the Accord Project logo in the navbar for use in the dark theme.

Screenshots or Video

Before-
After-

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Merging to main from fork:branchname

netlify[bot] commented 8 months ago

Deploy Preview for concerto-docs ready!

Name	Link
Latest commit	768d2a65525f0bc75efbbf144812ecea75b99c19
Latest deploy log	https://app.netlify.com/sites/concerto-docs/deploys/65fb0d62f4d3f20008d01eba
Deploy Preview	https://deploy-preview-40--concerto-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

apoorvsxna commented 8 months ago

@mttrbrts @sanketshevkar Could you review this pull request and let me know if anything requires changing?

sanketshevkar commented 7 months ago

Thanks for your contributions! @apoorvsxna we'll have a look!

apoorvsxna commented 7 months ago

Looks good! Please update your commits with DCO signoff

Hi @DianaLease. I messed something up while trying to add the DCO signoff to my commit. I ended up created a new PR, complete with the suggested changes and the signoff. I hope it resolves the issue. Thanks!