Open sstone1 opened 2 years ago
Hi, is this issue still open
Hi, Can I work on this issue? I have decent experience in this tech-stack. So, Please can you assign it to me?
I would like to request yout to assign this issue to me related to integrating the concerto
library modules into a React application.
Issue Summary:
Several concerto
modules (such as concerto-core
and concerto-tools
) require UMD versions generated using Webpack for browser compatibility. Currently, only concerto-core
has the browser
key set. To integrate these modules into a React application, additional polyfills and global variables are necessary due to missing Node.js core modules in the browser environment.
My Solution: To resolve this issue, I plan to:
concerto
modules include UMD-generated versions.I am confident that this approach will ensure seamless integration of the concerto
modules into the React application. Please let me know if you need any additional information or have any concerns regarding this request.
Currently, several modules have UMD versions generated using Webpack:
https://github.com/accordproject/concerto/blob/b05be1d6b619fcadd098b538b85895149ab6ac1d/packages/concerto-core/package.json#L14 https://github.com/accordproject/concerto/blob/b05be1d6b619fcadd098b538b85895149ab6ac1d/packages/concerto-tools/package.json#L13
Only
concerto-core
has thebrowser
key set though.However, in order to get this library integrated into a React application, I had to add the following polyfills and globals:
This may be as simple as ensuring that all of our modules include UMD generated versions, rather than anything wrong with the Webpack configuration.