accordproject / concerto

Business schema language and runtime

https://concerto.accordproject.org

Apache License 2.0

121 stars 106 forks source link

Fix: Prevent redefinition of imported types in model validation (#871) #902

Closed yashsaraswat2004 closed 4 weeks ago

yashsaraswat2004 commented 2 months ago

Closes #871

Changes

Added validation logic to check for name conflicts between local declarations and imported types.
Updated uniqueNames set to include imported types and prevent redefinition.

Flags

Ensure validation does not impact performance significantly.
Review the handling of imported namespaces across different modules.

Screenshots or Video

N/A

Related Issues

Issue #871

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests.
[x] Commits messages follow AP format.
[x] Extend the documentation, if necessary.
[x] Merging to main from fork:Yash_fixing-bugs.

dselman commented 1 month ago

You've reformatted the files making it very hard to review your changes. Can you please resubmit without reformatting?

yashsaraswat2004 commented 1 month ago

I'm really sorry to change the formatting of code. I will sure resubmit it without reformatting.