accordproject / concerto

Business schema language and runtime
https://concerto.accordproject.org
Apache License 2.0
122 stars 107 forks source link

refactor: Use Globalize for error formatting #917

Open AbhinRustagi opened 1 month ago

AbhinRustagi commented 1 month ago

Closes #838

Changes

Related Issues

Author Checklist

AbhinRustagi commented 1 month ago

Awesome, I'll update the rest of the files

AbhinRustagi commented 1 month ago

@dselman I see that there is no consistent way that the error message code has been crafted. In some cases, it is filename-function-error_type, in others it is filename-error_type. Which one do you think should be followed for consistency? I'd vote for the first kind.

AbhinRustagi commented 1 month ago

@dselman just following up

dselman commented 1 month ago

Your proposal works for me. 👌