search

accordproject / markdown-editor

Markdown editor based on Slate.js
Apache License 2.0
42 stars 47 forks source link

feat(hyperlink modal): added message for successful copy of a link url #391

Open nik72619c opened 4 years ago

nik72619c commented 4 years ago

Signed-off-by: Nikhil nikhilsharmarockstar21@gmail.com

Issue #379

### Changes - Created a new styled-component for displaying the success message - added state to toggle the message on copying the icon for the same
nik72619c commented 4 years ago

@DianaLease @irmerk @Michael-Grover please have a look :)

Michael-Grover commented 4 years ago

I'm not sure if this is entirely necessary. Google Docs doesn't do this but that's the only example I have had a chance to check. Do you know of any examples of a hyperlink copy confirmation in popular tools so we can see how they handle it?

If we choose to do this, I think the confirmation message should appear to the right of the icons so that the size of the modal and the position of the icons doesn't abruptly change image

nik72619c commented 4 years ago

thanks for the review @Michael-Grover . Making the changes !

elit-altum commented 4 years ago

@nik72619c If I copy a link once. The message will show. If I then change the link to some other value, and then try to copy it again in the same modal,the message still stays up and there would be no way for me to know that the new link was copied correctly or not.

Can we make linkCopied to false when the link value changes? What do you say?

jolanglinais commented 4 years ago

We're migrating this repository into web-components the next couple of days, so I'll be closing this soon and you should reopen there.