accordproject / markdown-transform

Parse and transform markdown text, including TemplateMark markdown templates

Apache License 2.0

71 stars 49 forks source link

Added roman and alphanumeric list feature #590

Open subhajit20 opened 6 months ago

subhajit20 commented 6 months ago

Closes https://github.com/accordproject/template-playground/issues/10

Added roman and alphanumeric list feature

Author Checklist

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

subhajit20 commented 6 months ago

I have only added the Roman list feature as of now. Any suggestion for an alphanumeric list @dselman

subhajit20 commented 5 months ago

hey @sanketshevkar @DianaLease can you guys review this pr and give me a feedback ?

sanketshevkar commented 5 months ago

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

subhajit20 commented 5 months ago

Can you please add a unit test / screenshot / screen-recording whichever you feel that can help us verify the changes you've made? Thanks.

Have one confusion that in the issue @dselman mentioned the markdown should have roman and alphanumeric list ... here what does markdown mean like there are multiple markdown packages I can see in the repo ... so which one should have that feature ?