chore(*): bump to Concerto v3 - Githubissues

accordproject / models

Accord Project Model Repository

https://models.accordproject.org

Apache License 2.0

29 stars 42 forks source link

chore(*): bump to Concerto v3 #161

Closed mttrbrts closed 2 years ago

mttrbrts commented 2 years ago

Upgrade the default Concerto engine in this repo to be v3.

Flags

concerto version statement will need to be amended once 3.0.0 is released.
Depends on a fix in concerto, https://github.com/accordproject/concerto/pull/527

Related Issues

Issue https://github.com/accordproject/concerto/issues/420

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to master from fork:branchname

dselman commented 2 years ago

Something funky with the HTML template...

dselman commented 2 years ago

We seem to be missing some namespaces in the deploy preview. E.g. I don't see a v3 version of this one: https://deploy-preview-161--accordproject-models.netlify.app/markdown/ciceromark@0.3.3.html

I suspect these are namespaces that have imports - i.e. their imports would need to be published first.