accordproject / template-archive

Smart Legal Contracts & Templating System
https://accordproject.org/projects/cicero/
Apache License 2.0
282 stars 119 forks source link

Backward compatibility for Accord Project Templates v0.6 #114

Closed jeromesimeon closed 6 years ago

jeromesimeon commented 6 years ago

There should be a way for the new version of Cicero (implementing v0.7 of the accord project template specification) to execute older templates (implementing v0.6 of the accord project template specification).

jeromesimeon commented 6 years ago

There are a couple of patches in #113 which should be replaced by a more robust/well tested approach.

jeromesimeon commented 6 years ago

Probably the execute call should detect whether it's running a v0.7 or v0.6 template https://github.com/accordproject/cicero/blob/master/packages/cicero-engine/lib/engine.js#L137

jeromesimeon commented 6 years ago

@mttrbrts @dselman feedback?

jeromesimeon commented 6 years ago

There was some follow up cleaning of the corresponding code. We won't support backward compatibility within the same Cicero engine. Closing.