feat(TemplateLibraries)- Support for private template libraries

mttrbrts commented 3 years ago

Co-authored-by: @Cronus1007

Fixes #164 and extends the work started in https://github.com/accordproject/cicero/pull/623

Changes

Add http auth parameter to TemplateLibrary.
Add http auth to getTemplate
Extend the tests.
Migrates from request-promise-native to axios to ensure consistency of HTTP libraries and to reduce dependencies

Related Issues

Issue #164

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[x] Extend the documentation, if necessary
[x] Merging to master from fork:branchname

Cronus1007 commented 3 years ago

@mttrbrts Thanks for taking this up. So shall I close #623. Plus a suugestion for the current PR is that since none of the repository package has their own package-lock.json so it would be better to remove this one so that the packages would be consistent.

mttrbrts commented 3 years ago

@mttrbrts Thanks for taking this up. So shall I close #623. Plus a suugestion for the current PR is that since none of the repository package has their own package-lock.json so it would be better to remove this one so that the packages would be consistent.

Yes, please. Thanks for the hint!

Cronus1007 commented 3 years ago

@mttrbrts Is the Pr ready to be merged?

mttrbrts commented 3 years ago

@mttrbrts Is the Pr ready to be merged?

@jeromesimeon @dselman @irmerk can I get a review, please?

accordproject / template-archive