Closed martinhalford closed 3 years ago
OK. Fair call. I'll add to those too.
@jeromesimeon @mttrbrts - I've refactored so that cicero invoke
and cicero initialize
both accept a --data
option now too.
I've had to make some significant changes to the validateInvokeArgs
, validateTriggerArgs
& validateInitializeArgs
to handle the scenario where either the--sample
option is provided --OR-- the --data
option is provided.
I've tried to ensure that, where needed, the logic looks for defaultSample
, defaultData
, defaultParams
or defaultState
.
Please let me know if you can see any issues.
@jeromesimeon - Fixed a small logic bug in validateInvokeArgs
which was causing the code to pickup defaultState
and defaultParams
when these options had been passed in. Apologies for the many commits.
@jeromesimeon Superseded by https://github.com/accordproject/cicero/pull/685 which is a cleaned up new PR based on this PR.
Closes #681
Changes
trigger
command.initialise
andinvoke
commands, for consistency.initialise
andinvoke
commands too.Flags
--data
flag is optional.--sample
flag andsample.md
.sample
ordata
exists. At least one must be specified.Example Usage