This is a draft PR to replace #709 which addresses some of the main issues with the original PR:
There are three major blocking issues with this PR:
Not properly based on the poc-slc branch
This PR is a proper extension of the poc-slc branch. The code was not rebased but instead is in a single new commit here:
deletes the whole cicero-transform package, instead importing a fixed version (why?!)
This PR properly depends on the cicero-transform package which is still present instead of deleted
tests are not passing (not sure why they aren't triggered on this PR). Below is a log
Two different issues with testing were fixed (with minimal knowledge of the intent):
some tests fails when the contract archive does not have history. this has been fixed by making history optional in the following commit:
Cicero-server tests fail due to a missing directory. This has been fixed by adding that directory back in the following commit:
As discussed during the last Tech WG call, I'm looking into recreating this PR properly.
Changes
Changes from #709 for storing contract state in .slc archives
Fixes issues with archives with no history
Fixes testing issues with cicero-server changes needing a missing directory
Fixes dependency issues with @accordproject/cicero-transform
Flags
Could not do a proper rebase due to a dirty git history and the large number of changes, this version loses authorship and individual commits from @sanketshevkar
Because of the testing issues and "hard reset" of the code, I have a somewhat lower confidence that this is a proper reflection of the original code and intent from its author. I will leave this leave this as a draft PR until I can get a review from @sanketshevkar and @martinhalford and confirmation that this is right
Coverage decreased (-0.4%) to 96.905% when pulling b21ce11baccb77c61a9507266ae7b6a565089892 on sanket-slc-history into 719594c11be69db165fbdb6a95bc917d991da49c on master.
Description
This is a draft PR to replace #709 which addresses some of the main issues with the original PR:
This PR is a proper extension of the
poc-slc
branch. The code was not rebased but instead is in a single new commit here:This PR properly depends on the
cicero-transform
package which is still present instead of deletedTwo different issues with testing were fixed (with minimal knowledge of the intent):
Changes
.slc
archivescicero-server
changes needing a missing directory@accordproject/cicero-transform
Flags