accordproject / template-archive

Smart Legal Contracts & Templating System
https://accordproject.org/projects/cicero/
Apache License 2.0
280 stars 119 forks source link

Sanket's PR on adding history to contract archives + fixes #713

Open jeromesimeon opened 2 years ago

jeromesimeon commented 2 years ago

Description

This is a draft PR to replace #709 which addresses some of the main issues with the original PR:

There are three major blocking issues with this PR:

  1. Not properly based on the poc-slc branch

This PR is a proper extension of the poc-slc branch. It has 3 commits on top of that branch instead of 42. The code was not rebased but instead is in a single new commit here: https://github.com/accordproject/cicero/pull/713/commits/dca4657c3ecad7dbdd6158ca85ea701e23cd14e7

  1. deletes the whole cicero-transform package, instead importing a fixed version (why?!)

This PR properly depends on the cicero-transform package which is still present instead of deleted

  1. tests are not passing (not sure why they aren't triggered on this PR). Below is a log

Two different issues with testing were fixed (with minimal knowledge of the intent):

  1. some tests fails when the contract archive does not have history. this has been fixed by making history optional in the following commit: https://github.com/accordproject/cicero/pull/713/commits/759fe68e20e0e19c5c46a40a2e43d1594ef41171
  2. Cicero-server tests fail due to a missing directory. This has been fixed by adding that directory back in the following commit: https://github.com/accordproject/cicero/pull/713/commits/b21ce11baccb77c61a9507266ae7b6a565089892

As discussed during the last Tech WG call, I'm looking into recreating this PR properly.

Changes

Flags

jeromesimeon commented 2 years ago

Turning this into a proper PR. This includes all the work from #709 which is now closed.