search

accordproject / template-archive

Smart Legal Contracts & Templating System
https://accordproject.org/projects/cicero/
Apache License 2.0
280 stars 119 forks source link

cicero verify does not report errors properly #729

Closed jeromesimeon closed 2 years ago

jeromesimeon commented 2 years ago

Bug Report 🐛

Cicero verify does not report errors properly.

Steps to Reproduce

In ./packages/cicero-core:

zsh-5.8$ ../cicero-cli/index.js verify --template test/data/verifying-template-signature/helloworldstateSigned 
cicero verify

verify the template signatures of the template author/developer

Options:
      --version   Show version number                                  [boolean]
  -v, --verbose                                                 [default: false]
      --help      Show help                                            [boolean]
      --template  path to the template                                  [string]
      --warnings  print warnings                      [boolean] [default: false]

TypeError: Cannot read property 'error' of undefined
jeromesimeon commented 2 years ago

It also silently reports successes:

zsh-5.8$ ../cicero-cli/index.js verify --template helloworldstate@0.15.0.cta 
zsh-5.8$
jeromesimeon commented 2 years ago

Only affected 0.23.0-alpha.1 (dependency issue in the CLI). Fixed in #730