Closed martinhalford closed 1 year ago
Let's go all the way and remove the dependency on Lerna.
Dan did a similar thing for markdown-transform recently, https://github.com/accordproject/markdown-transform/pull/570/files
Can you also review the GitHub Actions scripts (in
.github/workflows
) too? Especially the build and publish steps.
OK. Let me see what I can do.
Let's go all the way and remove the dependency on Lerna. Dan did a similar thing for markdown-transform recently, https://github.com/accordproject/markdown-transform/pull/570/files Can you also review the GitHub Actions scripts (in
.github/workflows
) too? Especially the build and publish steps.OK. Let me see what I can do.
@mttrbrts
I've removed Lerna completely. However, some stuff has been modified but not tested - most notably .github/workflows
which were copy/pastes of @dselman's code from Markdown Transform.
I've also tweaked the license.config.json
files; and renamed lerna.json
to config.json
and tweaked it, as that was still being referenced by scripts/timestamp.js
.
Totals | |
---|---|
Change from base Build 6096098290: | 0.0% |
Covered Lines: | 779 |
Relevant Lines: | 872 |
Closes #779
Lerna Bootstrap has been deprecated as of Lerna version 7.
The linking of
packages/*
is now handled bynpm
usingworkspaces
.Changes
lerna bootstrap
.workspaces
topackage.json
- so thatnpm
handles package linking."lerna": "^7.3.1",
lerna bootstrap
fromDEVELOPERS.md
.Author Checklist
--signoff
option of git commit.master
fromfork:branchname