Open mttrbrts opened 1 year ago
The JSON output is expected for complex types that don't have specific draft code baked in (eg MometaryAmount). We used to inline the space separated fields which was a hack and not localisation friendly. The template should render the fields of the Duration or we could bake in Duration drafting but we would need VOC support for enum values as well as an "as" formatting string.
Closes #797
Reimplememts
draft
command in cicero-cliChanges
draft
command to argstemplate-engine
to render in target format.Remaining tasks
-[ ] Add tests (taken from old code). The test run is currently failing because of low test coverage -[ ] Review command flags (utcOffset, offline, format, warning etc.). Some may no longer be necessary/possible. -[ ] Review the default target (
markdown
). Right now, the output includes in-lined JSON objects. I remember a bug around this, but I can't find a reference (@dselman ?). Example output:Author Checklist
--signoff
option of git commit.master
fromfork:branchname