accordproject / template-playground

Web Playground for TemplateMark templates
https://playground.accordproject.org
Apache License 2.0
17 stars 19 forks source link

feat: updated dropdown to conditionally render selected sample template name onclick #33

Closed Vinyl-Davyl closed 3 months ago

Vinyl-Davyl commented 5 months ago

@dselman @DianaLease @mttrbrts please review this when you’re available. Thanks

Vinyl-Davyl commented 5 months ago

Solved Issue https://github.com/accordproject/template-playground/issues/32

sanketshevkar commented 5 months ago

Can you please share a video / screenshot of the old and the new behavior?

Vinyl-Davyl commented 5 months ago

Can you please share a video / screenshot of the old and the new behavior?

Sure, definitely would do that right away for clarity

Vinyl-Davyl commented 5 months ago

Can you please share a video / screenshot of the old and the new behavior?

OLD: Notice the Load Sample Select drop on a sample template after load

1

Screenshot 2024-03-28 183247

Another Instance, The name of the loaded sample is not in any way being visible or indicated anywhere to show/clarify which load sample you're currently on 2

Screenshot 2024-03-28 183310

NEW: New updates made. The sample name is now conditionally rendered on the drop down showing and Indicating each load sample clicked on the drop down conditionally, depending on the name of the sample

1

Screenshot 2024-03-28 183453

2

Screenshot 2024-03-28 183621

3

Screenshot 2024-03-28 183653
sanketshevkar commented 3 months ago

@Vinyl-Davyl can you please fix the dco check?