accordproject / template-playground

Web Playground for TemplateMark templates
https://playground.accordproject.org
Apache License 2.0
15 stars 18 forks source link

feat(dev): semantic ui >>> antd #65

Closed Vinyl-Davyl closed 1 month ago

Vinyl-Davyl commented 2 months ago

Closes PR #55

Changes

Feat(dev): migration from Semantic UI to Ant Design

Author Checklist

Previews

Prev >> Semantic

Screenshot 2024-06-07 120254

Migrated >> AntD

Screenshot 2024-06-07 120146 Screenshot 2024-06-07 120210
sanketshevkar commented 2 months ago

Can you please rebase this with the main and add test cases as well?

Vinyl-Davyl commented 1 month ago

Hey @sanketshevkar @mttrbrts Added test cases on this already

sanketshevkar commented 1 month ago

I was suggesting to keep a dev branch separate for all 3 milestones. We could then test all the changes together at the end of the milestone and then merge all together.

On the DCO issue, I've provided more details on discord. I'll copy that here. Its not something David should be fixing. It's because my commit has mismatched DCO signoff for some reason.

@mttrbrts this issue seems extremely weird, nor I am able to point down the root cause neither able to come up with a temporary solution apart from manually passing the DCO check.

Issue: I do my dco signoffs with shevkar.sanket@gmail.com, for last commit that we merged in main its expecting a dco signoff from 43399522+sanketshevkar@users.noreply.github.com.

Anomaly: The PR DCO check had passed, once I merged into main it failed. Also my other commits that got merged last weekend have the same DCO signature and they all passed once merged in main shevkar.sanket@gmail.com, which seems to be failing for the latest commit. Should I manually pass the DCO check to unblock David?

mttrbrts commented 1 month ago

Thanks @sanketshevkar, I'm happy for you to manually sign-off the commit.

Let's use the GitHub Project to track the milestones (every PR should be linked to an issue in the project, or even linked directly!), I'd like to avoid long-running feature branches unless there are changes that we're very unsure about.

sanketshevkar commented 1 month ago

Great work @Vinyl-Davyl!!