Closed Vinyl-Davyl closed 1 month ago
Can you please rebase this with the main and add test cases as well?
Hey @sanketshevkar @mttrbrts Added test cases on this already
I was suggesting to keep a dev branch separate for all 3 milestones. We could then test all the changes together at the end of the milestone and then merge all together.
On the DCO issue, I've provided more details on discord. I'll copy that here. Its not something David should be fixing. It's because my commit has mismatched DCO signoff for some reason.
@mttrbrts this issue seems extremely weird, nor I am able to point down the root cause neither able to come up with a temporary solution apart from manually passing the DCO check.
Issue: I do my dco signoffs with shevkar.sanket@gmail.com, for last commit that we merged in main its expecting a dco signoff from 43399522+sanketshevkar@users.noreply.github.com.
Anomaly: The PR DCO check had passed, once I merged into main it failed. Also my other commits that got merged last weekend have the same DCO signature and they all passed once merged in main shevkar.sanket@gmail.com, which seems to be failing for the latest commit. Should I manually pass the DCO check to unblock David?
Thanks @sanketshevkar, I'm happy for you to manually sign-off the commit.
Let's use the GitHub Project to track the milestones (every PR should be linked to an issue in the project, or even linked directly!), I'd like to avoid long-running feature branches unless there are changes that we're very unsure about.
Great work @Vinyl-Davyl!!
Closes PR #55
Changes
Feat(dev): migration from Semantic UI to Ant Design
Author Checklist
--signoff
option of git commit.main
fromfork:branchname
Previews
Prev >> Semantic
Migrated >> AntD