accordproject / template-playground

Web Playground for TemplateMark templates

https://playground.accordproject.org

Apache License 2.0

15 stars 18 forks source link

fix(templates): render sample template name #66

Closed Vinyl-Davyl closed 1 month ago

Vinyl-Davyl commented 2 months ago

Closes PR #33

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[x] Vital features and changes captured in unit and/or integration tests
[x] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to main from fork:branchname

Previews

sanketshevkar commented 2 months ago

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

mttrbrts commented 2 months ago

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

Perhaps we could add PR deploys to netlify, like we have for other apps? Let me know if you need permissions

Vinyl-Davyl commented 2 months ago

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

okay, sure. would add some shots going on! it's a simplified PR fix from the other one closed though.

Vinyl-Davyl commented 2 months ago

Can you also please add screen recording videos of the changes? It'll be easier for us to visualize the changes as we don't have testing in place.

Perhaps we could add PR deploys to netlify, like we have for other apps? Let me know if you need permissions

👍🏼 we would look into this.

sanketshevkar commented 2 months ago

okay, sure. would add some shots going on! it's a simplified PR fix from the other one closed though.

Let me look at the netlify deployment, please rebase and add a unit test for this scenario. Considering this would be your first time writing unit tests, please give yourself sometime and get familiarized with react-testing-library and vitest.