accordproject / template-playground

Web Playground for TemplateMark templates
https://playground.accordproject.org
Apache License 2.0
15 stars 18 forks source link

feat(gui): template playground base footer #71

Closed Vinyl-Davyl closed 1 month ago

Vinyl-Davyl commented 1 month ago

Changes

Built foundational footer component for the Template Playground. Footer includes essential links and information, enhancing the overall user experience and providing easy access to relevant resources and community channels.

Screenshots or Video

Screenshot 2024-06-12 043538 Screenshot 2024-06-12 043553

Author Checklist

netlify[bot] commented 1 month ago

Deploy Preview for ap-template-playground ready!

Name Link
Latest commit f8655c92cf07708d6cc350022572c5692fe641df
Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/666ffe15ecc1220008ad1a9e
Deploy Preview https://deploy-preview-71--ap-template-playground.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sanketshevkar commented 1 month ago

image

Above is the loading screen that we can view from the PR deploy preview build. The footer should always be at the bottom of the screen. Even if the content is still loading. Perhaps we should add scrolling to the template output section so that the footer does not overflow? We should take this as separate task if solution needs changes to any other component other than the footer.

Vinyl-Davyl commented 1 month ago

image

Above is the loading screen that we can view from the PR deploy preview build. The footer should always be at the bottom of the screen. Even if the content is still loading. Perhaps we should add scrolling to the template output section so that the footer does not overflow? We should take this as separate task if solution needs changes to any other component other than the footer.

it definitely need change in the other components. thanks, would look into this later.

dselman commented 1 month ago

The AP logo is strange on Safari. Displays as three dots and then when you click it you get this...

image
Vinyl-Davyl commented 1 month ago

The AP logo is strange on Safari. Displays as three dots and then when you click it you get this...

image

hmm, that's quite odd for a view on desktop, how about your other browsers? have you tried it there too? let me know what it looks like on your end. I know as of now that's how it looks on mobile. but it shouldn't be a prop because we have optimizations for different browsers then mid/large screen sizes in the pipeline. https://deploy-preview-71--ap-template-playground.netlify.app/