accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 95 forks source link

Issue #184 solved - Long Template Name intersects with Logo #233

Closed naveen8801 closed 3 years ago

naveen8801 commented 3 years ago

Closes #184

This pull request solves the mentioned issue by changing the CSS styling of logo in ' LibraryItemCard.js ' .

Changes

This issue is solved by changing ' itemLogoStyle ' in ' LibraryItemCard.js ' :

NOW ->

const itemLogoStyle = { maxHeight: "20px", float: "right", display: "inline-block", objectFit: "contain", };

INITIALLY ->

const itemLogoStyle = { position: 'absolute', top: '13px', right: '16px', maxHeight: '23px', };

Now if , logo src property is passed to Image component then logo will be visible and text will be wrapped around logo as shown in screenshot .

Flags

Logo src property must passed as a props to Image component to see the changes .

Screenshots or Video

Screenshot (11)_LI

Author Checklist

irmerk commented 3 years ago

I believe the changes from ' to " broke the code and resulted in the errors?

8:18:20 AM: ERR! => Failed to build the preview
8:18:20 AM: ERR! .storybook/preview.js-generated-config-entry.js
8:18:20 AM: ERR! You attempted to import /opt/build/repo/node_modules/@storybook/client-api which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.
8:18:20 AM: ERR! You can either move it inside src/, or add a symlink to it from project's node_modules/.