accordproject / web-components

React Components for Accord Project
Apache License 2.0
120 stars 101 forks source link

fix(ui-markdown-editor):multi-para to list proper indent - I158 #252

Closed K-Kumar-01 closed 3 years ago

K-Kumar-01 commented 3 years ago

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

Closes #158

Choosing multiple paragraphs and then converting them to list will now show points-bullet or numbers along with the indentation

Changes

Screenshots or Video

Selecting from bottom Screenshot from 2021-02-20 23-49-03 Result Screenshot from 2021-02-20 23-49-10

Author Checklist

Michael-Grover commented 3 years ago

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman

K-Kumar-01 commented 3 years ago

@K-Kumar-01 , it looks like there are some unsuccessful checks. If you need help, I recommend asking @irmerk or @dselman @Michael-Grover I am unable to understand the failure of the checks. @irmerk @dselman Could you please tell me what is the error?

jolanglinais commented 3 years ago

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

K-Kumar-01 commented 3 years ago

The error logs look strange to me... @K-Kumar-01 I'd suggest force pushing the same code up to force Netlify to rebuild and we can see what the issue is.

@irmerk I have added a commit(comment added) as I was not confident about force push. @Michael-Grover The PR build is successful now. Let me know if there are any changes required.