accordproject / web-components

React Components for Accord Project

Apache License 2.0

120 stars 101 forks source link

Closed gatij10 closed 3 years ago

gatij10 commented 3 years ago

Signed-off-by: Gatij Taranekar gatij.taranekar@gmail.com

Closes #255

[ ] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to master from fork:branchname
[ ] Manual accessibility test performed
- [ ] Keyboard-only access, including forms
- [ ] Contrast at least WCAG Level A
- [ ] Appropriate labels, alt text, and instructions

dselman commented 3 years ago

Your fix works, but I don't understand why we need both <blockquote> and <q> tags.

My understand is that <blockquote> should be used for quoted paragraphs, while <q> is for shorter inline quotes.

It feels like this could be a css issue with the <blockquote> tag. https://css-tricks.com/examples/Blockquotes/

Could you please investigate whether we can apply css to the <blockquote> tag to fix this, rather than wrapping everything in <q>?

gatij10 commented 3 years ago

@dselman I have added Css to the blockquotes and deleted the q tag. https://www.loom.com/share/ba4f2ae08be648d6bcc01ac9a53a4f7b