accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 94 forks source link

#278 Solved - Paragraph styling options obscured by Clause Template #300

Closed naveen8801 closed 3 years ago

naveen8801 commented 3 years ago

Closes #278

This issue is solved by changing some style (z -index) .

Changes

Changes are made in style of ' ClauseWrapper ' in index.js of ' Clause ' under ui-contract-editor .

Before -

  style = {{
                userSelect: `${props.readOnly ? 'text' : 'none'}`,
                padding: '3px',
       }}

After -

 style = {{
                userSelect: `${props.readOnly ? 'text' : 'none'}`,
                padding: '3px',
                zIndex: '-1',
       }}

Screenshots or Video

After changes - Screenshot (23)

Author Checklist

d-e-v-esh commented 3 years ago

@naveen8801 Were you able to replicate the issue locally? For some reason, this issue was not appearing on my local build and it was working like normal. And I think you should turn off the prettier extension so it would be easier to look at the changes that you have made.

naveen8801 commented 3 years ago

@naveen8801 Were you able to replicate the issue locally? For some reason, this issue was not appearing on my local build and it was working like normal. And I think you should turn off the prettier extension so it would be easier to look at the changes that you have made.

Hii @d-e-v-esh , you should check this https://github.com/accordproject/web-components/blob/79bc7d143ae01cdc01c379116962a26675b89f77/packages/ui-contract-editor/src/components/Clause/index.js#L118.

OS - windows 10

irmerk commented 3 years ago

I believe @d-e-v-esh is working on #278?

d-e-v-esh commented 3 years ago

@irmerk I haven't started on this issue yet, so you can assign this to him if this PR is good.

naveen8801 commented 3 years ago

@irmerk I haven't started on this issue yet, so you can assign this to him if this PR is good.

thanks @d-e-v-esh

d-e-v-esh commented 3 years ago

@naveen8801 There was some problem probably but now I'm able to replicate the issue too. So that's great. You have two commits where if I'm not mistaken the second one doesn't do anything. You can clean that up.