accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 94 forks source link

Can't Delete image in Markdown editor #320

Closed Aniruddha-Shriwant closed 3 years ago

Aniruddha-Shriwant commented 3 years ago

Bug Report 🐛

See this Loom video where I had tried to delete the text and image but the image was not able to delete Loom link : https://www.loom.com/share/558b1ef9151c45e59de3962ec62def4b Or see this video:

https://user-images.githubusercontent.com/58624108/112434714-e64fbd00-8d69-11eb-9937-01f9828cf010.mp4

Expected Behavior

By selecting the image and then clicking the delete/backspace image should get deleted

Current Behavior

By selecting the image and then clicking the delete/backspace image was not deleted

Possible Solution

Steps to Reproduce

  1. Go to markdown editor (https://ap-web-components.netlify.app/?path=/story/markdown-editor--demo)
  2. Try to add an image or use an existing sample image
  3. Select the image and try to delete it with the delete/backspace key

Context (Environment)

Desktop

Detailed Description

Possible Implementation

d-e-v-esh commented 3 years ago

I would like to work on this issue.

Aniruddha-Shriwant commented 3 years ago

@d-e-v-esh, I was willing to work on this but as I'm currently busy with my end-semester examinations, you may take this 👍🏻

d-e-v-esh commented 3 years ago

@Aniruddha-Shriwant My exams just got finished so I'd be happy to work on this. Thanks man 👍

dezfuture commented 3 years ago

I would like to work and fix this issue. Can you guide me through how to contribute

d-e-v-esh commented 3 years ago

@dezfuture I have started working on this issue. You can look for more issues or find what you like from the list.

K-Kumar-01 commented 3 years ago

@irmerk Since the issue was open for many days with no activity on it. I have created a PR that might be able to solve the issue.