search

accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 94 forks source link

Styling-Library #333

Open K-Kumar-01 opened 3 years ago

K-Kumar-01 commented 3 years ago

Feature Request 🛍️

Currently, from ui-components we import a Library component. We do not have the ability to provide custom styling to this which I suggest here.

Use Case

The issue will make the library more customizable and user-friendly.

Context

The need for this issue is stated here

Detailed Description

The proper implementation of this issue would be providing the user with 4-5 keys namely:

  1. style - styling the whole component
  2. uploadStyle - styling the component which allows custom uploads
  3. searchBarStyle - styling the searchbar
  4. itemwrapperstyle - styling the div which encompasses the item list
  5. itemStyle - styling each item of the list

Would you like to work on the issue?

Yes

irmerk commented 3 years ago

I think @algomaster99, @Michael-Grover, and @dselman will have insight into this.

Michael-Grover commented 3 years ago

I think it would be nice for apps that use the library component in their UI to style it to match their UI, if that's what this issue is suggesting.

K-Kumar-01 commented 3 years ago

I think it would be nice for apps that use the library component in their UI to style it to match their UI, if that's what this issue is suggesting.

@Michael-Grover Do you mean using the classes provided by the component to style it? :thinking:

algomaster99 commented 3 years ago

Completely forgot to look at this. But yes, there is a need for custom styling. You may work on this issue if you want.

Michael-Grover commented 3 years ago

@K-Kumar-01 I don't know much about classes and components, you would have to ask a front-end engineer about that (I'm a UX Designer). I think making the library more customizable and user friendly sounds good though.

K-Kumar-01 commented 3 years ago

@K-Kumar-01 I don't know much about classes and components, you would have to ask a front-end engineer about that (I'm a UX Designer). I think making the library more customizable and user friendly sounds good though.

@Michael-Grover I think @irmerk @DianaLease or @dselman can help here so tagging them.

AbhishekJamhoriya commented 2 years ago

@K-Kumar-01 can i work on this issue.

K-Kumar-01 commented 2 years ago

@AbhishekJamhoriya Sure, go ahead.

arpitmaurya commented 2 years ago

Hi @irmerk @DianaLease @dselman @Michael-Grover can you assign this work to me, am MERN DEVELOPER i like contribution in this project

AniruddhaSoni commented 1 year ago

Hey @Michael-Grover, Can I work on this issue?

Michael-Grover commented 1 year ago

@AniruddhaSoni thanks for volunteering! I'm not sure if this issue should still be open though, it's a year and a half old and it's not clear to me what this issue is proposing. @DianaLease @mttrbrts @irmerk Do you think this is still a good issue to work on, or should it be closed?