accordproject / web-components

React Components for Accord Project

Apache License 2.0

117 stars 94 forks source link

Catch onChange exceptions for issue #335 #337

Closed dselman closed 3 years ago

dselman commented 3 years ago

Signed-off-by: Dan Selman danscode@selman.org

Closes #335

Catches exceptions raised by the onChange handler registered with the markdown-editor, preventing them from crashing the editor.

Changes

Wrap onChange in try/catch and log to the console

Author Checklist

[x] Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
[ ] Vital features and changes captured in unit and/or integration tests
[ ] Commits messages follow AP format
[ ] Extend the documentation, if necessary
[ ] Merging to master from fork:branchname
[ ] Manual accessibility test performed
- [ ] Keyboard-only access, including forms
- [ ] Contrast at least WCAG Level A
- [ ] Appropriate labels, alt text, and instructions

cypress[bot] commented 3 years ago

Test summary

1 • 0 • 0 • 0

Run details


Project	web-components
Status	Passed
Commit	08220b1436
Started	May 5, 2021 2:26 PM
Ended	May 5, 2021 2:27 PM
Duration	01:23 💡
OS	Linux Ubuntu - 20.04
Browser	Chrome 90

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard