accordproject / web-components

React Components for Accord Project

Apache License 2.0

117 stars 94 forks source link

Change in Demo Text Of Markdown Editor #339

Open d-e-v-esh opened 3 years ago

d-e-v-esh commented 3 years ago

Bug Report 🐛

As we have discussed in this thread and in this post, we should replace the terminology of hardBreak and softBreak with lineBreak and paragraphBreak that is causing confusion.

@jeromesimeon also suggested to do the same here. We are not going to be using those terminologies in the code so having them in the UI will just create more confusion in the future. This would obviously make more sense after #270 is resolved and implemented.

In the deploy preview of #270, this is how the demo text appears.

Current Behavior

chrome_WGN8HYULHq

Expected Behavior

chrome_z6q4JdDvhz

lineBreak => shift + enter paragraphBreak => enter

Desktop

OS: Windows 10
Browser: Chrome
Version 90.0.4430.93 (Official Build) (64-bit)

irmerk commented 3 years ago

@jeromesimeon pinging you on this again. If this looks good, please label it.

Pravenn18 commented 2 years ago

I have fixed this issue #370 please review it and closes the issue