accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 94 forks source link

Adding Background In Inline Code #341

Closed d-e-v-esh closed 3 years ago

d-e-v-esh commented 3 years ago

Feature Request 🛍️

Inline code is used to insert code snippets in the middle of the normal text line. In the markdown-editor, it currently looks like this:

image

As you can see, it is really difficult to identify the bit of inline code. This is because the only thing differentiating the normal text from inline code is the font we are using.

This is how other text editors render inline code:

Notion:

Notion_Heq5CO1IUA

Typora:

Typora_EHlTLsAFCn

GitHub Markdown:

chrome_KpTkf7I09J

StackOverflow:

chrome_vw7NBxjxlV

Implementation

Michael-Grover commented 3 years ago

This sounds good to me. Let's see how a light gray background looks

K-Kumar-01 commented 3 years ago

@Michael-Grover I would like to work on the issue. I have already prepared the code for it. Can I make a PR?

Michael-Grover commented 3 years ago

sure, unless @d-e-v-esh would like to. I assume @d-e-v-esh made the issue because he wants to work on it? @d-e-v-esh what do you think?

d-e-v-esh commented 3 years ago

@Michael-Grover Yes, I want to work on this. Do you have any suggestions for the color of the inline code text? Or should I do what I feel is the best?

Michael-Grover commented 3 years ago

@d-e-v-esh let's try black text for now. I'll assign the issue to you since you created it.

Michael-Grover commented 3 years ago

@K-Kumar-01 @d-e-v-esh feel free to share code and collaborate on the issue