accordproject / web-components

React Components for Accord Project
Apache License 2.0
117 stars 94 forks source link

feat(ui-components): filter templates by cicero version - #67 #369

Closed TC5022 closed 2 years ago

TC5022 commented 2 years ago

Signed-off-by: TC5022 tanyac5022002@gmail.com

Closes #67

Added a dropdown that filters templates based on their cicero version.

Changes

Added a filter that uses the cicero version of the templates by building on PR #187.

Screenshots or Video

image image

Author Checklist

TC5022 commented 2 years ago

Requesting a review @irmerk @mttrbrts

irmerk commented 2 years ago

I haven't looked into the code yet, but curious why there is an undefined option in the dropdown?

TC5022 commented 2 years ago

That is because I haven't defined Cicero Version for one of the items in the library. I did that because all the library items aren't templates and hence all of them may not have a Cicero Version

TC5022 commented 2 years ago

Are any changes required @irmerk?

irmerk commented 2 years ago

This looks good to me. I'd like to get @mttrbrts to review as well.

TC5022 commented 2 years ago

Thankyou @irmerk @mttrbrts for your reviews. Working on these changes.

TC5022 commented 2 years ago

Made the required changes @mttrbrts

image

The styling looks better now

image

And all the items with no cicero version will be bundled in the "Unknown" category

mttrbrts commented 2 years ago

It's looking great! It should appear in the hosted Storybook straightaway and will be available to use in the next release.

Thanks for you contribution. 🌟

TC5022 commented 2 years ago

Thank you so much!