accosine / hapi-relax

Wraps nano's API as hapi server methods and seamlessly authenticates with CouchDB via cookie
BSD 2-Clause "Simplified" License
4 stars 1 forks source link

Hapi v17 #5

Open henrikruscon opened 6 years ago

henrikruscon commented 6 years ago

I made a PR #4 that updates hapi-relax to Hapi v17 but it lacks full testing coverage.

Would be sweet if anyone is able to contribute ✌️

Basically nock has to be updated and stop using nockDone(), same with lab where it has to stop using done(). Additionally the register method of plugins is incorrect, it has to be a promise or async/await. ~Finally the config needs to replace register with plugin.~

dkolba commented 6 years ago

@henrikdahl we are not actively using this library atm, would you be willing to maintain it yourself?

henrikruscon commented 6 years ago

@dkolba Sure ✌️

dkolba commented 6 years ago

@henrikdahl alright, you are a collaborator now. Have fun!