search

accounts-js / accounts

Fullstack authentication and accounts-management for Javascript.
https://www.accountsjs.com/
MIT License
1.5k stars 141 forks source link

fix(typeorm): fix query in findUserByServiceId #1108 #1109

Closed blessanabraham closed 3 years ago

blessanabraham commented 3 years ago

This fixes the find query in findUserByServiceId

Fixes: #1108

codecov[bot] commented 3 years ago

Codecov Report

Merging #1109 (5a6d75f) into master (232de32) will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
+ Coverage   95.53%   95.58%   +0.04%     
==========================================
  Files          91       91              
  Lines        2152     2152              
  Branches      418      418              
==========================================
+ Hits         2056     2057       +1     
+ Misses         95       94       -1     
  Partials        1        1
Impacted Files Coverage Δ
packages/database-typeorm/src/typeorm.ts 99.52% <ø> (+0.47%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 232de32...fa6053c. Read the comment docs.

pradel commented 3 years ago

@blessanabraham can you uncomment the tests merged in the other pr? From my understanding, they should work with the fix right?

blessanabraham commented 3 years ago

Yes, it's running as I am writing this

pradel commented 3 years ago

Thanks for the fix @blessanabraham!