search

accounts-js / accounts

Fullstack authentication and accounts-management for Javascript.
https://www.accountsjs.com/
MIT License
1.5k stars 141 forks source link

chore(password)!: await sendVerificationEmail during user signup #1113

Closed pradel closed 3 years ago

pradel commented 3 years ago

BREAKING CHANGE: The createUser function now await sendVerificationEmail only if sendVerificationEmailAfterSignup is true. This change was made to be able to run this function in lambda.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1113 (401dde6) into master (232de32) will increase coverage by 0.04%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
+ Coverage   95.53%   95.58%   +0.04%     
==========================================
  Files          91       91              
  Lines        2152     2151       -1     
  Branches      418      418              
==========================================
  Hits         2056     2056              
+ Misses         95       94       -1     
  Partials        1        1
Impacted Files Coverage Δ
packages/database-typeorm/src/typeorm.ts 99.52% <ø> (+0.47%) :arrow_up:
packages/password/src/accounts-password.ts 91.82% <66.66%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2450f33...401dde6. Read the comment docs.