search

accounts-js / accounts

Fullstack authentication and accounts-management for Javascript.
https://www.accountsjs.com/
MIT License
1.5k stars 141 forks source link

docs(server): add impersonation docs #1199

Closed BarbecueSilver closed 3 years ago

BarbecueSilver commented 3 years ago

Related to discussion https://github.com/accounts-js/accounts/discussions/1195

changeset-bot[bot] commented 3 years ago

⚠️ No Changeset found

Latest commit: d9ae1dbec352c62363b1516b5d600fb79118f90b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

pradel commented 3 years ago

@BarbecueSilver I feel like all this part should be moved on the server page rather than the client. The client could reference that part of the server page tho to make it easier to find.

BarbecueSilver commented 3 years ago

@pradel good point. Will move it there :)

BarbecueSilver commented 3 years ago

@pradel good 2 go :rocket:

codecov[bot] commented 3 years ago

Codecov Report

Merging #1199 (d9ae1db) into master (c6b79ad) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files         106      106           
  Lines        2377     2377           
  Branches      498      473   -25     
=======================================
  Hits         2265     2265           
- Misses        103      107    +4     
+ Partials        9        5    -4
Impacted Files Coverage Δ
packages/oauth/src/accounts-oauth.ts 88.88% <0.00%> (ø)
packages/server/src/accounts-server.ts 90.70% <0.00%> (ø)
...s/graphql-api/src/utils/authenticated-directive.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6b79ad...d9ae1db. Read the comment docs.

BarbecueSilver commented 3 years ago

@pradel all done :rocket: :partying_face:

pradel commented 3 years ago

@BarbecueSilver amazing, thanks 🚀