accumulator / Quickddit

Reddit client for Jolla's SailfishOS, Ubuntu Touch and Nokia N9
GNU General Public License v3.0
53 stars 21 forks source link

Thumbnails too small on larger screens (Fairphone 2, Nexus 5) #16

Closed sam-hobbs closed 8 years ago

sam-hobbs commented 8 years ago

Hi,

This is one of my favourite Sailfish apps, thanks for all the hard work on it.

I think I read in a changelog a while back that you had done some work to make the UI scalable, which is great if I'm not misremembering. Is it possible to tweak the thumbnails so that they are larger on bigger screens? They are too small to be easily visible on Fairphone 2 (1290x1080 5" screen), but the same feed viewed on Jolla looks great.

Here's Quickddit on Fairphone 2 (ithumbnails too small): screenshot-16-05-10-20-43-26 - quickddit

And here's Neliapila on Fairphone 2 (thumbnails easily visible): screenshot-16-05-10-20-41-47 - neliapila

Something closer to the Neliapila scale would be great, if that's possible?

accumulator commented 8 years ago

can you download the latest from openrepos, start quickddit from the terminal, and report what PPI is detected?

I believe you reported earlier on openrepos that the scaling worked on a Nexus? If so, I suspect the Fairphone port doesn't report the PPI correctly..

Thanks.

sam-hobbs commented 8 years ago

Test with latest version:

[nemo@localhost ~]$ harbour-quickddit
[D] QWaylandEglClientBufferIntegration::QWaylandEglClientBufferInte
gration:62 - Using Wayland-EGL
[D] QMLUtils::setPScale:212 - Device PPI = 100 scale =  1
[W] DeclarativeWindow::DeclarativeWindow:93 - No default allowed or
ientations defined. Check your device configuration!

I remember the changes you made in response to that comment on openrepos made a difference, but I think I responded before I tested it fully (got excited by the changelog!). I don't have the N5 anymore but I'll ask someone to do the test on TMO and post it here for you, and attach a screenshot if possible.

accumulator commented 8 years ago

Thanks for the quick response.

Like I suspected, the PPI is not correctly reported on the Fairphone2 port. A Full HD 5" screen should report a PPI of around 440. This is the reason the scaling isn't applied. (Jolla's PPI is 242)

accumulator commented 8 years ago

Closing this, as there is a workaround by manually setting thumbnail scale in the settings menu.